Changed datetime and timestamp types to honor precision and default to 0 digit precision #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hydrocharged
approved these changes
Aug 16, 2023
…ype check or the max precision version
zachmu
force-pushed
the
zachmu/timestamp
branch
from
6ecac3e
to
55c14f0
Compare
max-hoffman
added a commit
that referenced
this pull request
Aug 17, 2023
* Name resolution refactor * [ga-format-pr] Run ./format_repo.sh to fix formatting * Revert "Merge pull request #1944 from dolthub/zachmu/timestamp" This reverts commit ca69015, reversing changes made to c11b504. * srid * merge revert --------- Co-authored-by: max-hoffman <max-hoffman@users.noreply.github.com> Co-authored-by: Zach Musgrave <zach@dolthub.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the MySQL behavior.
Partial fix for dolthub/dolt#6503